feat: 数字と漢数字が連続しているケースにおいて、数字と漢数字は別のブロックとして解析を行う #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiyonori-matsumoto ありがとうございます！なるほど、確かにこの方法だとうまくいきそうですね。 |
keichan34
reviewed
Oct 19, 2023
test/main.test.ts
Outdated
| expect(res).toStrictEqual({"pref": "東京都", "city": "千代田区", "town": "三番町", "addr": "2-4三町KSビル10階", "lat": 35.690557, "lng": 139.743591, "level": 3}) | ||
| }) | ||
|
|
||
| test('東京都千代田区神田美土代町９番地７千代田２１ビル７階(「7千代田」が「7000代田」になる)', async () => { |
There was a problem hiding this comment.
細かいのですが、こちらのテスト名内の「「7千代田」が「7000代田」になる」というのは「「7千代田」が「7000代田」にならない」というこどですよね。。？
There was a problem hiding this comment.
はい、あっています。
#186
のIssue中の文言をそのままテストケースに持ってきてしまっていました。
「ならない」に変更しますね 🙇
There was a problem hiding this comment.
@keichan34 こちら以下のコミットで対応しました
b36b174
|
@kiyonori-matsumoto こちらの機能を取り込んだバージョンをv2.10.0 としてリリースしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186
のいくつかの問題を解決するためのPRになります
数字と漢数字を連続した一つの数字ブロックとして扱ってしまうことで諸々の問題につながっているため、数字と漢数字を独立した数字ブロックとして扱うように修正を加えています