Commands refactor

[gjmooney]

This replaces all the separate commands we had for creating sources and layers with one createEntry that takes all the necessary arguments to pass to the CreationFormDialog, and I attempted to standardize how we handle icons and labels. I also wanted to have a consistent naming pattern so I changed the names of the commands that create a source and layer at the same time to new{type}Entry to differentiate those from the source/layer only commands. This also re-orders some functions to try and keep the order consistent between our constants, commands, context menus, and the toolbar.

[github-actions]

👈 Launch a Binder on branch gjmooney/jupytergis/commands_refactor

[brichet]

Thanks, this looks good.

I just have a comment below.

EDIT:
Actually there are a bunch of functions that may be removed from the Private namespace of commands.ts, IIUC

• createRasterDemSource
• createVideoSource
• createImageSource
• createVectorLayer
• createHillshadeLayer
• createVideoLayer
• createImageLayer

[brichet]

Wondering if we want to add these ones to the palette.
These commands need to have an item selected in side panel. But when the item is selected, it seems easier to type Del or F2 instead of opening the command palette and search for the command...

[gjmooney]

EDIT: Actually there are a bunch of functions that may be removed from the Private namespace of commands.ts, IIUC

* `createRasterDemSource`

* `createVideoSource`

* `createImageSource`

* `createVectorLayer`

* `createHillshadeLayer`

* `createVideoLayer`

* `createImageLayer`

I thought I got rid of those, must've snuck back in when I rebased 😂

That's a good point about the palette commands, I'll take out the ones with keyboard shortcuts.

[brichet]

I don't know if this PR is ready yet, but currently it seems that some layers have a wrong icon

[gjmooney]

I don't know if this PR is ready yet, but currently it seems that some layers have a wrong icon

Images and videos are raster layers. I was thinking we could add an icon or sourceType or something like that to the IJGISLayer and load the icon from that here.

[brichet]

Images and videos are raster layers. I was thinking we could add an icon or sourceType or something like that to the IJGISLayer and load the icon from that here.

OK, I didn't realize that.
I think that we should keep it that way for now, to avoid some unnecessary complexity in code.

[brichet]

Thanks @gjmooney, this looks good