Skip to content

Enable empty path for geojson layer #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Jul 11, 2025

Description

Create an empty vector layer with empty embedded data when no path is provided

Screencast.From.2025-07-11.16-00-04.mp4

📚 Documentation preview: https://jupytergis--810.org.readthedocs.build/en/810/
💡 JupyterLite preview: https://jupytergis--810.org.readthedocs.build/en/810/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch HaudinFlorence/jupytergis/enable_empty_path_for_geojson_layer

@HaudinFlorence HaudinFlorence force-pushed the enable_empty_path_for_geojson_layer branch from 2f4e6b8 to 84f9d5d Compare July 11, 2025 14:06
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Integration tests report: appsharing.space

@HaudinFlorence HaudinFlorence self-assigned this Jul 11, 2025
@HaudinFlorence HaudinFlorence added the enhancement New feature or request label Jul 11, 2025
@mfisher87
Copy link
Member

How can we indicate to the user that this is what is happening?

What about a checkbox "Create an empty GeoJSON layer. I will add my own data with the draw tool."?

@HaudinFlorence
Copy link
Contributor Author

HaudinFlorence commented Jul 11, 2025

How can we indicate to the user that this is what is happening?

What about a checkbox "Create an empty GeoJSON layer. I will add my own data with the draw tool."?

You are right that it would be more explicit to better inform the user. I will try to propose something.

@HaudinFlorence
Copy link
Contributor Author

We previously decided to propose to add this message in brackets If no path/url is provided, an empty GeoJSON is created, but that's probably not enough.

@mfisher87
Copy link
Member

mfisher87 commented Jul 11, 2025

Dynamic "Field A || Field B" interactions are one of those cases that I think is really hard with our generate-forms-from-schemas technique. I'm not sure how to resolve this yet. Maybe this is something we can brainstorm together at a hackathon!

@HaudinFlorence HaudinFlorence force-pushed the enable_empty_path_for_geojson_layer branch 2 times, most recently from 5b5818a to eca455f Compare July 15, 2025 08:47
@martinRenou martinRenou force-pushed the enable_empty_path_for_geojson_layer branch from eca455f to 45a4f00 Compare July 15, 2025 12:49
@HaudinFlorence
Copy link
Contributor Author

bot please update snapshots

@martinRenou
Copy link
Member

@HaudinFlorence please undo the bot's commit, it's not using the right command, resulting in those files being added with the wrong names.

We should update the bots to use the latest of https://github.com/geojupyter/jupytergis/blob/main/.github/workflows/update_galata_references.yaml#L104 (replace v1 -> main like in https://github.com/jupytercad/JupyterCAD/blob/main/.github/workflows/update_lite_galata_references.yaml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants