Add GeoPackage data format #709
Draft
+517
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
# Conflicts: # packages/base/src/constants.ts # packages/base/src/toolbar/widget.tsx # python/jupytergis_lab/jupytergis_lab/notebook/objects/__init__.py # yarn.lock
|
Integration tests report: appsharing.space |
mfisher87
reviewed
Jun 4, 2025
packages/base/src/tools.ts
Outdated
|
|
||
| const tables = gpkg.getFeatureTables(); | ||
| const features: GeoJSON.Feature[] = []; | ||
| for (const tableName of tables) { |
There was a problem hiding this comment.
Ideally, the user should get a chance to choose which table(s) they want to load. Maybe that could be a future PR though :)
packages/base/src/tools.ts
Outdated
| for (const tableName of tables) { | ||
| const dao = gpkg.getFeatureDao(tableName); | ||
| const bbox = dao.getBoundingBox(); | ||
| const iter = gpkg.queryForGeoJSONFeaturesInTable(tableName, bbox); |
There was a problem hiding this comment.
I'm not sure how I feel about converting the data to GeoJSON. Have you looked in to https://github.com/richard-thomas/ol-load-geopackage ? (I'm not sure how it works under the hood, maybe it loads from GeoJSON too 😆 )
There was a problem hiding this comment.
Should we extend the jupyterlab webpack config? https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html#custom-webpack-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for GeoPackage data format, both to UI and to Python API, using the library geopackage-js.
I added a test for Python API but didn't add a UI test. I also did not add support for exporting GeoPackage layers to QGIS. If asked, I can do these either in this PR or another PR.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--709.org.readthedocs.build/en/709/
💡 JupyterLite preview: https://jupytergis--709.org.readthedocs.build/en/709/lite