Create the conda environment after downloading the extension artifacts #705
Conversation
|
|
|
Integration tests report: appsharing.space |
.github/workflows/build.yml
Outdated
| cp ./jupytergis_core/dist/jupytergis*.whl jupytergis_core-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis_lab/dist/jupytergis*.whl jupytergis_lab-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis_qgis/dist/jupytergis*.whl jupytergis_qgis-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis_lite/dist/jupytergis*.whl jupytergis_lite-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis/dist/jupytergis*.whl jupytergis-0.0.1-py3-none-any.whl |
There was a problem hiding this comment.
We need these files so that jupytergis is installed in the kernel env (for the python API)
There was a problem hiding this comment.
Yeah right.
Looks like this would need some cleanup at some point. Maybe it would then make sense to create a new lite/build-environment.yml file to list build dependencies and include these extensions.
.github/workflows/build.yml
Outdated
| cp ./jupytergis_qgis/dist/jupytergis*.whl jupytergis_qgis-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis_lite/dist/jupytergis*.whl jupytergis_lite-0.0.1-py3-none-any.whl | ||
| cp ./jupytergis/dist/jupytergis*.whl jupytergis-0.0.1-py3-none-any.whl | ||
| pip install ./jupytergis_core/dist/jupytergis*.whl ./jupytergis_lab/dist/jupytergis*.whl ./jupytergis_qgis/dist/jupytergis*.whl ./jupytergis_lite/dist/jupytergis*.whl ./jupytergis/dist/jupytergis*.whl |
There was a problem hiding this comment.
Not sure if it makes sense to install them all in the lite environment, but it probably doesn't hurt.
Let's see if the CI passes at least.
| @@ -279,6 +279,7 @@ jobs: | |||
| cp ./jupytergis_qgis/dist/jupytergis*.whl jupytergis_qgis-0.0.1-py3-none-any.whl | |||
| cp ./jupytergis_lite/dist/jupytergis*.whl jupytergis_lite-0.0.1-py3-none-any.whl | |||
| cp ./jupytergis/dist/jupytergis*.whl jupytergis-0.0.1-py3-none-any.whl | |||
| pip install ./jupytergis_core/dist/jupytergis*.whl ./jupytergis_lab/dist/jupytergis*.whl ./jupytergis_lite/dist/jupytergis*.whl ./jupytergis/dist/jupytergis*.whl | |||
There was a problem hiding this comment.
We're already handling the whls in the jupyterlite-xeus environment here: https://github.com/geojupyter/jupytergis/blob/main/lite/environment.yml#L18
I believe we should fix jupyterlite/xeus#227
There was a problem hiding this comment.
Adding a note that we need to keep it that way so that the Python API of JupyterGIS is available in the emscripten environment.
Installing those wheels in the host environment will result in an unneeded (harmless but unneeded) duplication of labextensions, so I'd suggest not applying this change.
There was a problem hiding this comment.
Thanks for opening this though! That made me realize the actual issue jupyterlite/xeus#227 which was fairly hard to understand 😅
Description
To check if that fixes jupyterlite/jupyterlite#1644
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--705.org.readthedocs.build/en/705/
💡 JupyterLite preview: https://jupytergis--705.org.readthedocs.build/en/705/lite