Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3d displays #64

Merged
merged 20 commits into from
Jul 26, 2024
Merged

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jul 19, 2024

#51

  • Support adding terrain objects
  • Add UI element to add terrain
  • Add Raster DEM sources to source panel context menu
  • Add hillshade layers to layer panel context menu
  • Add palette command to remove terrain

hillshade

terrain

Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/3d-terrain

@gjmooney gjmooney changed the title Add support 3d displays Add support for 3d displays Jul 23, 2024
@gjmooney gjmooney added the enhancement New feature or request label Jul 25, 2024
@gjmooney gjmooney marked this pull request as ready for review July 26, 2024 07:43
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!!

In follow-up PRs:

  • Similar to the approach we take to save the map center and zoom level in the file, we could save the pitch and rotation of the map. That would make sense now that we have a way to load 3D data
  • It would be great to have a color picker in the hillshade layer form (See base/src/formbuilder/objectform/vectorlayerform.ts for an example of this):
    Screenshot from 2024-07-26 10-06-43

examples/3d_terrain.jGIS Outdated Show resolved Hide resolved
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 2a59733 into geojupyter:main Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants