Notebook API

[martinRenou]

Also fix #39

Screencast.from.2024-07-11.13-15-38.mp4

[github-actions]

👈 Launch a Binder on branch martinRenou/jupytergis/notebook_api

[martinRenou]

The GeoJSON layer works great @brichet !

[davidbrochart]

Strangely, when I run this code I cannot see anything in the notebook, unlike in the separately opened test.jGIS document:

from jupytergis_lab import GISDocument

doc = GISDocument("test.jGIS")
doc

[davidbrochart]

That's because I didn't install your branch 😄

[martinRenou]

Actually I think you found a bug.

It seems the CSS of maplibre is not in the page unless you already opened a jGIS file, I'll look into it

[davidbrochart]

I cannot add the GeoJSON layer, is that what you are referring to?

[martinRenou]

I cannot add the GeoJSON layer, is that what you are referring to?

No, do you have an error?

[davidbrochart]

No, no error even if the file path is wrong.

[davidbrochart]

No Python error but lots of errors in the browser console, just after adding the raster layer:

Error: sources.6a45e5b3-1dd1-4739-9d94-afdbaced5bb5: missing required property "data"
Error: layers.20136e59-358a-438f-8d3e-7f5668483fb0: source "6a45e5b3-1dd1-4739-9d94-afdbaced5bb5" not found
Error: Cannot style non-existing layer "20136e59-358a-438f-8d3e-7f5668483fb0".
...

[martinRenou]

please update snapshots!!!

[martinRenou]

@davidbrochart thanks for the review!

[brichet]

Thanks @martinRenou, I had some minor changes.
We'll update it in a follow up PR.

[brichet]

Suggested change

	private updateOptions(options: IJGISOptions) {
	updateOptions(options: IJGISOptions) {

This one should probably not be private, since it is supposed to be implemented by plugins.

[brichet]

Suggested change

	path: str = None,
	data: Dict = None,
	path: str | None = None,
	data: Dict | None = None,