Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ShapeFiles #164

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Add test for ShapeFiles #164

merged 4 commits into from
Oct 1, 2024

Conversation

arjxn-py
Copy link
Contributor

A follow up for #141

Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/shp-test

@martinRenou
Copy link
Member

Thanks! The example directory is more for documentation I would say, those are available in https://geojupyter.github.io/jupytergis/lab/index.html for users to play with JupyterGIS.

So could you rename your file from examples/shapefileTest.jGIS to examples/shapefile.jGIS?

If you will to add a test that runs on the CI to make sure shapefile support does not break in time, we could add a test file in the ui-tests/tests/gis-files folder and make sure it opens there (by adding it to the list of tested files https://github.com/geojupyter/jupytergis/blob/main/ui-tests/tests/ui.spec.ts#L7)

@arjxn-py
Copy link
Contributor Author

arjxn-py commented Sep 30, 2024

Thanks for letting me know, this is so helpful
I'll be on it.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arjxn-py, LGTM.
The test failure seems to be related to #162

@martinRenou martinRenou merged commit 459b18a into geojupyter:main Oct 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants