automate updating, for the most part. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cleaned up the lib itself to pass jshint and change up how it preloads a bit. |
|
|
||
| This package contains an update script that can pull the files from MaxMind and handle the conversion from CSV. | ||
| A npm script alias has been setup to make this process easy. Please keep in mind this requires internet and MaxMind | ||
| rate limits that amount of downloads on thier servers. |
There was a problem hiding this comment.
ah will patch it up.
|
Any chance you could split this into two separate commits? One to do the jshint stuff and the other to add new features? |
|
if i could recall all the tweaks but its all mixed at this point. if see parts you just dont like or question, just let me know everyone has their prefs. |
|
This looks very useful, was about to start doing something similar. Is it ready to be pulled? |
bluesmoon
added a commit
that referenced
this pull request
Mar 18, 2013
automate updating, for the most part.
Closed
|
I had forgot about this but it should still work fine |
STRML
pushed a commit
to STRML/node-geoip-country-only
that referenced
this pull request
Sep 12, 2016
automate updating, for the most part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built a small updater that took most of what you had manual and made it handle it with download, extract, process flow. also updates to Dec 2012 data.