Repository navigation
Restore secure MCP execution and bundled pack recovery - #653
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidekick's tightened authorization made ordinary MCP client execution hard to bootstrap: a service credential scoped only for pack viewing and management could not authorize standard tool execution. Separately, an upgrade had left bundled Jellyfin compatibility modules with stale provenance, while the security checks correctly refused to load them.
This change restores the intended workflows without weakening the security boundary.
Changes
tools.executeas the default scope; keep pack read/manage permissions optional and separately granted.Security properties
origin/maindeployment path after merge.Verification
Passed on this branch:
node --check static/dashboard.jsnode --check src/packs/bundled.jsnode --check src/index.jsnode --test test/security-dashboard-service-credentials.test.js test/jellyfin-lifecycle.test.js- 8 tests passednpm run test:packs- 41 tests passednpm run test:dashboard- 63 tests passednpm run check:testsnpm run check:docsgit diff --checkDeployment
After merge, deploy from a clean
maincheckout using the documented deployment procedure. Verify the deployed commit and service health afterward.