Bugfix: reset allows custom initial value, loadAll updates currentIndex #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Floodgate#reset
to explicitly pass newinitial
value to newFloodgate#queue
generatorFloodgate#loadAll
not updatingFloodgate#state.currentIndex
Why:
exportState
is saved by that parent, and Floodgate is toggled between mounted instances in a "loadComplete === true
" stateexportState
could save thecurrentIndex
value which could then be mapped to theinitial
prop when re-mountedinitial
value is equal to the length of thedata
prop's value, making thereset
method uselessload
methodsHow:
initial
property to theFloodgate#reset
method's parameterFloodgate#props.initial
Floodgate#state.currentIndex
to the length ofFloodgate#data
Reference:
Closes #40
Closes #41