Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various text updates #35

Merged
merged 4 commits into from
May 2, 2019
Merged

Various text updates #35

merged 4 commits into from
May 2, 2019

Conversation

geographika
Copy link
Member

This pull request contains the following:

  • addition of installaition instructions on Windows to README.md
  • removal of specific OSGeoLive version numbers (the workshop works fine on more recent versions)
  • various typo fixes, rewording, and clarifications following a full run through of the workshop - please revert any of these if it is felt they do not improve readibility

marcjansen
marcjansen approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for this. I think I found one tiny spelling thing, which I'll commit on top of your work. Just correct this again if you as a natural tongue disagree :-)

src/map-component/dissecting-example.md

Try to resize your browser window and see that the viewport (and the containing map component) always fill out the full area of the browser window.
Try to resize your browser window and notice that the viewport (and the containing map component) always fill out the full area of the browser window.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Try to resize your browser window and notice that the viewport (and the containing map component) always fill out the full area of the browser window.
Try to resize your browser window and notice that the viewport (and the containing map component) always fills out the full area of the browser window.

@marcjansen marcjansen merged commit 0f8d267 into geoext:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcjansen marcjansen marcjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geographika @marcjansen