Skip to content

fix: restrict acess for non admin profile - #203

Open
skmbaye wants to merge 1 commit into
geodes-sms:mainfrom
skmbaye:fix-permission-issues
Open

fix: restrict acess for non admin profile#203
skmbaye wants to merge 1 commit into
geodes-sms:mainfrom
skmbaye:fix-permission-issues

Conversation

@skmbaye

@skmbaye skmbaye commented May 28, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@esyriani
esyriani requested a review from gauranshkumar June 11, 2026 12:44
@esyriani

Copy link
Copy Markdown
Member

@skmbaye There are too many files modified that shouldn't be there.

Comment thread cside/media/images/demo1779375486.jpg Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many random pictures please check this and remove all added by you in this folder.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll check this as soon as possible

@gauranshkumar

gauranshkumar commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Hello @skmbaye As Eugene mentioned earlier, there are just too many random files and images, so unfortunately I can't review this PR. As a guess for so many changes is probably a file mod change (if this is the case check this out to help you https://www.geeksforgeeks.org/git/how-to-make-git-ignore-file-permission-chmod-changes/) and if not then you are using CRLF instead of LF as your line ending (in this case refer to this nice read https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/) If both of them doesn't fix the issue then let me know, but I am gussing these should be the core problems. Until you fix these, I can't review the PR.

@skmbaye
skmbaye force-pushed the fix-permission-issues branch from a04beba to 1b60355 Compare June 22, 2026 18:20
@skmbaye

skmbaye commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@gauranshkumar my apologies for the previous mess with line endings.

I've cleaned up the branch:

  • Reset to main and reapplied only the real changes
  • Fixed CRLF/LF inconsistencies between my local files and the repository (the Dockerfile was the main culprit)
  • Force-pushed the cleaned-up branch

The diff is now 4 files / ~140 lines, all directly related to the IDOR fix and its Dockerfile prerequisite. Ready for review :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants