Skip to content

Fix #23: remove str_replace that mangled LaTeX-encoded titles #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulesBlanchard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #23: remove str_replace that mangled LaTeX-encoded titles #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 49 additions & 55 deletions relis_app/controllers/Paper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,54 +100,54 @@ public function list_paper($paper_cat = 'all', $val = "_", $page = 0, $dynamic_t
$view_link_url = "";
foreach ($ref_table_config['links'] as $link_type => $link) {
if (!empty($link['on_list'])) { {
$link['type'] = $link_type;
if (empty($link['title'])) {
$link['title'] = lng_min($link['label']);
}
$push_link = false;
switch ($link_type) {
case 'add':
$add_link = true; //will appear as a top button
if (empty($link['url']))
$add_link_url = 'manager/add_element/' . $ref_table;
else
$add_link_url = $link['url'];
break;
case 'view':
if (!isset($link['icon']))
$link['icon'] = 'folder';
if (empty($link['url']))
$link['url'] = 'manager/display_element/' . $ref_table . '/';
$push_link = true;
break;
case 'edit':
if (!isset($link['icon']))
$link['icon'] = 'pencil';
if (empty($link['url']))
$link['url'] = 'manager/edit_element/' . $ref_table . '/';
$push_link = true;
break;
case 'delete':
if (!isset($link['icon']))
$link['icon'] = 'trash';
if (empty($link['url']))
$link['url'] = 'manager/delete_element/' . $ref_table . '/';
$link['type'] = $link_type;
if (empty($link['title'])) {
$link['title'] = lng_min($link['label']);
}
$push_link = false;
switch ($link_type) {
case 'add':
$add_link = true; //will appear as a top button
if (empty($link['url']))
$add_link_url = 'manager/add_element/' . $ref_table;
else
$add_link_url = $link['url'];
break;
case 'view':
if (!isset($link['icon']))
$link['icon'] = 'folder';
if (empty($link['url']))
$link['url'] = 'manager/display_element/' . $ref_table . '/';
$push_link = true;
break;
case 'edit':
if (!isset($link['icon']))
$link['icon'] = 'pencil';
if (empty($link['url']))
$link['url'] = 'manager/edit_element/' . $ref_table . '/';
$push_link = true;
break;
case 'delete':
if (!isset($link['icon']))
$link['icon'] = 'trash';
if (empty($link['url']))
$link['url'] = 'manager/delete_element/' . $ref_table . '/';
$push_link = true;
break;
case 'add_child':
if (!isset($link['icon']))
$link['icon'] = 'plus';
if (!empty($link['url'])) {
$link['url'] = 'manager/add_element_child/' . $link['url'] . "/" . $ref_table . "/";
$push_link = true;
break;
case 'add_child':
if (!isset($link['icon']))
$link['icon'] = 'plus';
if (!empty($link['url'])) {
$link['url'] = 'manager/add_element_child/' . $link['url'] . "/" . $ref_table . "/";
$push_link = true;
}
break;
default:
break;
}
if ($push_link)
array_push($list_links, $link);
}
break;
default:
break;
}
if ($push_link)
array_push($list_links, $link);
}
}
}
/*
Expand Down Expand Up @@ -1307,7 +1307,7 @@ private function paper_exist($paper_array)
}

/**
* checks if a paper already exists based on the DOI or title/authors,
* checks if a paper already exists based on the DOI or title/authors,
* and then inserts the paper into the database with the appropriate values and relationships with authors
*/
private function insert_paper_bibtext($paper_array)
Expand Down Expand Up @@ -1699,10 +1699,7 @@ private function get_bibler_result($bibtex, $operation = "single")
$error = 0;
$year = !empty($Tres['entry']['year']) ? $Tres['entry']['year'] : "";
$paper_array['bibtexKey'] = str_replace('\\', '', $Tres['entry']['entrykey']);
$title = !empty($Tres['entry']['title']) ? $Tres['entry']['title'] : "";
$title = str_replace('{', '', $title);
$title = str_replace('\\', '', $title);
$paper_array['title'] = str_replace('}', '', $title);
$paper_array['title'] = !empty($Tres['entry']['title']) ? $Tres['entry']['title'] : "";
$paper_array['preview'] = !empty($Tres['preview']) ? $Tres['preview'] : "";
$paper_array['bibtex'] = !empty($Tres['bibtex']) ? $Tres['bibtex'] : "";
$paper_array['abstract'] = !empty($Tres['entry']['abstract']) ? $Tres['entry']['abstract'] : "";
Expand Down Expand Up @@ -1731,10 +1728,7 @@ private function get_bibler_result($bibtex, $operation = "single")
$paper['venueId']=$venue_id;
}*/
$paper['bibtexKey'] = str_replace('\\', '', $value['entry']['entrykey']);
$title = !empty($value['entry']['title']) ? $value['entry']['title'] : "";
$title = str_replace('{', '', $title);
$title = str_replace('\\', '', $title);
$paper['title'] = str_replace('}', '', $title);
$paper['title'] = !empty($value['entry']['title']) ? $value['entry']['title'] : "";
$paper['preview'] = !empty($value['preview']) ? $value['preview'] : "";
$paper['bibtex'] = !empty($value['bibtex']) ? $value['bibtex'] : "";
$paper['abstract'] = !empty($value['entry']['abstract']) ? $value['entry']['abstract'] : "";
Expand Down
Loading