Added option to force curl to use IPv4 #1412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fleeym
requested changes
Jul 3, 2025
loader/src/utils/web.cpp
Outdated
| if (Mod::get()->getSettingValue<bool>("curl-force-ipv4")) { | ||
| curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4); | ||
| } else { | ||
| curl_easy_setopt(curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V6); |
There was a problem hiding this comment.
The default should be CURL_IPRESOLVE_WHATEVER imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble with Curl. The literal only way I could get it to work was forcing it to use IPv4 instead of IPv6. Geode doesn't have an option to force IPv4 (not that I know of at least) so I added this. Made the shit work for me. Hopefully this could help someone in the future, too.