Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder ch2 #736

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Reorder ch2 #736

merged 3 commits into from
Jan 25, 2022

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Jan 25, 2022

@Robinlovelace please take a look, let me know what you think about it, and improve if needed. The main changes are:

  1. I added a diagram showing the relationship between different sf building blocks (inspired by @defuneste)
  2. I changed the order of sections -- now the sf section is before sfg and sfc sections. My thinking is that most people should know about sf, but not as many need to know about sfg...

image

@Robinlovelace
Copy link
Collaborator

Taking a look 👀

Robinlovelace
Robinlovelace approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comment that could be tweaked in post merge commit (or not at all as it's such a minor comment). I think this is a clear win for readers.

02-spatial-data.Rmd
To learn more about building sf geometries from scratch read the following Sections \@ref(sfg) and \@ref(sfc).

```{r 02-sfdiagram, fig.cap="Building blocks on sf objects."}
knitr::include_graphics("figures/02-sfdiagram.png")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment here: shouldn't we add

# source("code/02-sfdiagram.R")

Above the line to show the code that generates the diagram?

02-spatial-data.Rmd
@@ -444,6 +444,74 @@ plot(st_as_sfc("GEOMETRYCOLLECTION (MULTIPOINT (5 2, 1 3, 3 4, 3 2), LINESTRING
par(old_par)
```

### The sf class {#sf}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 👍 to mentioning sf class first.

@Nowosad
Copy link
Member Author

Nowosad commented Jan 25, 2022

Thanks, Robin.

@Nowosad Nowosad merged commit c74c220 into main Jan 25, 2022
@Nowosad Nowosad deleted the reorder-ch2 branch January 25, 2022 13:38
github-actions bot pushed a commit that referenced this pull request Jan 25, 2022
@Nowosad
Deploy commit: Merge pull request #736 from Robinlovelace/reorder-ch2
1fe3433 
Reorder ch2 c74c220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robinlovelace Robinlovelace Robinlovelace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nowosad @Robinlovelace