Prevent GeocoderService from instantiating providers on boot #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could cause performance issues as is instantiates the each provider that was setup in the configuration as the time of boot, event if they don't get use.
Korri
force-pushed
the
no-instantiation-on-boot
branch
from
1a484b2 to
6637132
Compare
|
Hi @Korri Thanks for submitting this PR. I will take a look at this over the next few weeks. I won't have time this weekend, but hopefully by next weekend. |
mikebronner
changed the base branch from
master
to
feature/optimize-service-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code creates an instance of each configured provider directly in the boot method (side effect of
registerProvidersFromConfig), this is not good practice as most likely this library won't be used on every request.In my case it would cause a bigger issue as we do
composer installbefore having a.envfile created, and this issue would causeartisan discoverto fail as it was trying to instantiate some providers without an API key.