Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-170: Add device orientation to geolocation button - #minor #965

Closed
wants to merge 29 commits into from
Closed

PB-170: Add device orientation to geolocation button - #minor #965

wants to merge 29 commits into from

Conversation

LukasJoss
Copy link
Contributor

@LukasJoss LukasJoss commented Jun 26, 2024 •
edited
Loading

Add vision cone to geolocation if information is available through geolocation api or magnetometer to indicate the users orientation.
If a magnetometer is available, clicking the geolocation a second time will rotate the map to align it to north

Test link

@github-actions github-actions bot changed the title very wip very wip - #minor Jun 26, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 26, 2024 •
edited
Loading

Passing run #2995 ↗︎

0 211 21 0 Flakiness 0

Details:

PB-170: Add debug statements and clean up code
Project: web-mapviewer Commit: cf87b6226c
Status: Passed Duration: 04:45 💡
Started: Jul 16, 2024 10:06 AM Ended: Jul 16, 2024 10:10 AM

Review all test suite changes for PR #965 ↗︎

@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch 3 times, most recently from a72d79c to 0ed8c6b Compare July 1, 2024 14:14
@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch from 412469e to 78d0ccf Compare July 4, 2024 11:03
LukasJoss and others added 23 commits July 4, 2024 15:07
@LukasJoss
very wip
62cb1be
@pakb @LukasJoss
WIP also (iOs s**t)
24e72b1
@pakb @LukasJoss
debouncing gyroscope event handling
61cd4bd
@pakb @LukasJoss
WIP
8b688ee
@pakb @LukasJoss
WIP
51b235e
@LukasJoss
change debounce time
1e74954
@pakb @LukasJoss
WIP
03c0b85
@pakb @LukasJoss
WIP
2ac9de0
@LukasJoss
PB-170: Add flag to indicate if auto rotate is enabled
4d1818d
@LukasJoss
PB-170: Move autorotate logic to openlayers to reduce store access
97cfe51
@LukasJoss
PB-170: Add damping to rotation
0a1c369
@LukasJoss
PB-170: Clean up code
862fd17
@LukasJoss
PB-170: Use circular mean to calculate average angle
25dcdf8
@LukasJoss
PB-170: Add orientation-certainty and -delta thresholds
f8c49c8
@pakb @LukasJoss
PB-170 : adding a cone to show where the device is pointing (compass)
fdc2885
@pakb @LukasJoss
PB-170 : take device pixel ration into account
34a2c5c 
the vision cone is otherwise too small on Retina devices (iPhone and such)
@LukasJoss
PB-170: Update icons
da33a8e
@LukasJoss
PB-170: Make vision cone read value from device orientation
d1628c6
@LukasJoss
PB-170: Add reading of heading from geolocation
f048483
@LukasJoss
PB-170: Calculate effective offset from geolocation and device orient…
142f145 
…ation
@LukasJoss
PB-170: Update interval of vision cone
df8081f
@LukasJoss
PB-170: Check if device orientation is absolute
86bcd34
@LukasJoss
PB-170: Restructure code to show vision cone conditionally
770f972
@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch from 78d0ccf to c39a9e4 Compare July 4, 2024 13:07
@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch from c39a9e4 to 3314576 Compare July 4, 2024 13:22
@LukasJoss LukasJoss requested review from ltshb, pakb and ltkum July 4, 2024 13:32
ltshb
ltshb reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this PR ? What should I review ? Could you please update the PR title to provide information on what is asked to review here

@LukasJoss LukasJoss changed the title very wip - #minor PB-170: Add device orientation to geolocation button Jul 8, 2024
@github-actions github-actions bot changed the title PB-170: Add device orientation to geolocation button PB-170: Add device orientation to geolocation button - #minor Jul 8, 2024
@LukasJoss LukasJoss requested a review from ltshb July 8, 2024 09:16
ltshb
ltshb reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get the auto rotation and based on the PR description it seems that it don't work, at least on my mobile phone touching geolocation again would disable the geolocation and not re-orient to the north if not in the north.

@LukasJoss
Copy link
Contributor Author

LukasJoss commented Jul 8, 2024 •
edited
Loading

I don't fully get the auto rotation and based on the PR description it seems that it don't work, at least on my mobile phone touching geolocation again would disable the geolocation and not re-orient to the north if not in the north.

Does your device have absolute orientation (magnetic sensors)? If not this is expected behavior with the current code as pressing the geolocation button again should just turn off the geolocation if the phone does not have absolute orientation

@LukasJoss LukasJoss requested a review from ltshb July 16, 2024 09:05
@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch from e98c8fc to cf87b62 Compare July 16, 2024 10:02
@LukasJoss LukasJoss force-pushed the feat-PB-170-device-orientation branch from 3831d08 to 5be76ac Compare July 16, 2024 12:56
@ltshb
Copy link
Contributor

ltshb commented Aug 7, 2024

is replaced by #1022

@ltshb ltshb closed this Aug 7, 2024
@ltshb ltshb mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb Awaiting requested review from pakb

@ltkum ltkum Awaiting requested review from ltkum

@ltshb ltshb Awaiting requested review from ltshb

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasJoss @ltshb @pakb