Skip to content

PB-2234: disable custom Cesium post-processing#1579

Merged
pakb merged 1 commit intodevelopfrom
fix-PB-2234-3d-viewer-artifacts
Mar 4, 2026
Merged

PB-2234: disable custom Cesium post-processing#1579
pakb merged 1 commit intodevelopfrom
fix-PB-2234-3d-viewer-artifacts

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Feb 27, 2026

What was working with previous version of Cesium is now creating rendering artifacts with our terrain (see ticket https://swissgeoplatform.atlassian.net/browse/HDG-43 )

Disabling all post-processing is removing all these artifacts, and it also should render things a bit faster

Test link

@github-actions github-actions bot added the bug label Feb 27, 2026
@cypress
Copy link

cypress bot commented Feb 27, 2026

web-mapviewer    Run #6526

Run Properties:  status check passed Passed #6526  •  git commit 1c4a712f99: PB-2234: disable custom Cesium post-processing
Project web-mapviewer
Branch Review fix-PB-2234-3d-viewer-artifacts
Run status status check passed Passed #6526
Run duration 06m 48s
Commit git commit 1c4a712f99: PB-2234: disable custom Cesium post-processing
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 261
View all changes introduced in this branch ↗︎

Copy link
Contributor

@sommerfe sommerfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried multiple times to zoom in on the landscape to see if the artifacts are still visible or not, but every time after some zooming i got this error, if i remember correctly we had this once before, maybe thats why we added the post-processing?
Image

@pakb
Copy link
Contributor Author

pakb commented Feb 27, 2026

I tried multiple times to zoom in on the landscape to see if the artifacts are still visible or not, but every time after some zooming i got this error, if i remember correctly we had this once before, maybe thats why we added the post-processing?

I tried to pin-point if this error was linked to the same issue, but it doesn't look like so. It is linked to the label layer that isn't behaving well within the newer Cesium engine.
If you zoom in too quickly it kind of breaks the engine. (and if you disable labels and zoom in quickly, nothing breaks)

@sommerfe
Copy link
Contributor

I tried multiple times to zoom in on the landscape to see if the artifacts are still visible or not, but every time after some zooming i got this error, if i remember correctly we had this once before, maybe thats why we added the post-processing?

I tried to pin-point if this error was linked to the same issue, but it doesn't look like so. It is linked to the label layer that isn't behaving well within the newer Cesium engine. If you zoom in too quickly it kind of breaks the engine. (and if you disable labels and zoom in quickly, nothing breaks)

ok thanks for clarification, it might make sense to add a comment of this break to the label layer, also maybe add a coment to the CesiumMap.vue to explain why post processing is not added, so in the future we do not add it back again and have the same issue again

@ismailsunni
Copy link
Contributor

I got a different error, but most probably it's not related

image

@pakb pakb force-pushed the fix-PB-2234-3d-viewer-artifacts branch 3 times, most recently from d10e861 to 4a33241 Compare March 3, 2026 15:35
What was working with previous version of Cesium is now creating rendering artifacts with our terrain (see ticket https://swissgeoplatform.atlassian.net/browse/HDG-43 )

Disabling all post-processing is removing all these artifacts, and it also should render things a bit faster
@pakb pakb force-pushed the fix-PB-2234-3d-viewer-artifacts branch from 4a33241 to 1c4a712 Compare March 3, 2026 16:30
@pakb
Copy link
Contributor Author

pakb commented Mar 4, 2026

As discussed, this won't fix the error that pops up when the label are screwing the Cesium engine, only the artifacts on the terrain.
We'll see if we can live with this label creating error on production or we will need to do something about it later

@pakb pakb requested a review from sommerfe March 4, 2026 07:11
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the stripe in the test link 👍

@pakb pakb merged commit 90f4169 into develop Mar 4, 2026
6 checks passed
@pakb pakb deleted the fix-PB-2234-3d-viewer-artifacts branch March 4, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants