PB-2234: disable custom Cesium post-processing#1579
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-2234-3d-viewer-artifacts
|
| Run status |
|
| Run duration | 06m 48s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
20
|
|
|
0
|
|
|
261
|
| View all changes introduced in this branch ↗︎ | |
I tried to pin-point if this error was linked to the same issue, but it doesn't look like so. It is linked to the label layer that isn't behaving well within the newer Cesium engine. |
ok thanks for clarification, it might make sense to add a comment of this break to the label layer, also maybe add a coment to the CesiumMap.vue to explain why post processing is not added, so in the future we do not add it back again and have the same issue again |
d10e861 to
4a33241
Compare
What was working with previous version of Cesium is now creating rendering artifacts with our terrain (see ticket https://swissgeoplatform.atlassian.net/browse/HDG-43 ) Disabling all post-processing is removing all these artifacts, and it also should render things a bit faster
4a33241 to
1c4a712
Compare
|
As discussed, this won't fix the error that pops up when the label are screwing the Cesium engine, only the artifacts on the terrain. |
ismailsunni
left a comment
There was a problem hiding this comment.
I don't see the stripe in the test link 👍


What was working with previous version of Cesium is now creating rendering artifacts with our terrain (see ticket https://swissgeoplatform.atlassian.net/browse/HDG-43 )
Disabling all post-processing is removing all these artifacts, and it also should render things a bit faster
Test link