PB-1140: add a minimal scale for print specs #1124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1140-minimal-scale-for-printing
|
| Run status |
|
| Run duration | 04m 59s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
151
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/drawing.cy.js • 1 failed test • e2e/electron/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
sommerfe
approved these changes
Nov 12, 2024
ltkum
force-pushed
the
fix-PB-1140-minimal-scale-for-printing
branch
2 times, most recently
from
88eb429
to
4cee955
Compare
Issue : When sending a print spec, if the scale was too small, it would be sent to the backend in a scientific notation (for example : '1.00045e-11px'), which couldn't be interpreted by the backend. Fix : We set a new minimal scale value to ensure we always send readable specs, which is enforced as long as the scale is greater than 0.
ltkum
force-pushed
the
fix-PB-1140-minimal-scale-for-printing
branch
from
4cee955
to
9b34bd6
Compare
|
I can't reproduce the failing tests locally. In both case, it says that 'process' is not defined, and I can find it in the package lock as a dependency for cypress. I don't know exactly why those tails consistently fail, but my guess is that it has nothing to do with the current code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : When sending a print spec, if the scale was too small, it would be sent to the backend in a scientific notation (for example : '1.00045e-11px'), which couldn't be interpreted by the backend.
Fix : We set a new minimal scale value to ensure we always send readable specs, which is enforced as long as the scale is greater than 0.
Test link