PB-977: Don't use service-proxy for internal domain and for GPX that support CORS - #patch #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-977-proxy
|
| Run status |
|
| Run duration | 04m 55s |
| Commit |
|
| Committer | Brice Schaffner |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
ltshb
force-pushed
the
bug-PB-977-proxy
branch
5 times, most recently
from
b0b7f17
to
555957d
Compare
…support CORS GPX file used always the service-proxy even if the server supported CORS. Also on the service-proxy we could see that some requests were made over service-proxy for internal server like public.geo.admin.ch. This was due to the fact that if for any reason the initial request failed (network failure) we fallback to the service proxy. Now in that case we don't fallback anymore. NOTE unfortunately there is no way for a web application to check for CORS support see https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors
ltshb
force-pushed
the
bug-PB-977-proxy
branch
from
555957d
to
2dcf44e
Compare
pakb
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPX file used always the service-proxy even if the server supported CORS. Also
on the service-proxy we could see that some requests were made over service-proxy
for internal server like public.geo.admin.ch. This was due to the fact that if
for any reason the initial request failed (network failure) we fallback to the
service proxy. Now in that case we don't fallback anymore.
NOTE unfortunately there is no way for a web application to check for CORS support
see https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors
Test link