Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-865 : remove forced clampToGround for KML polyline in 3D #1049

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Aug 30, 2024

KML are well able to set that themselves if they require it, and some use cases need this to be false (flight tracks)

fixes #1016

Test link

@github-actions github-actions bot added the bug label Aug 30, 2024
Copy link

cypress bot commented Aug 30, 2024

web-mapviewer    Run #3171

Run Properties:  status check passed Passed #3171  •  git commit 3c06267c85: PB-865 : remove forced clampToGround for KML polyline in 3D
Project web-mapviewer
Branch Review fix-PB-865-no-clamptoground-for-3d-kml
Run status status check passed Passed #3171
Run duration 04m 43s
Commit git commit 3c06267c85: PB-865 : remove forced clampToGround for KML polyline in 3D
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

KML are well able to set that themselves if they require it, and some use cases need this to be false (flight tracks)
@pakb pakb force-pushed the fix-PB-865-no-clamptoground-for-3d-kml branch from f0f7fab to 3c06267 Compare September 2, 2024 06:05
@pakb pakb merged commit ef1ddba into develop Sep 2, 2024
5 of 6 checks passed
@pakb pakb deleted the fix-PB-865-no-clamptoground-for-3d-kml branch September 2, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression of PR885 - Flight tracks are unexpectedly clampedToGround
2 participants