Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB 898 Fix rumantsch footer link to geo.admin.ch - #patch #1045

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

schtibe
Copy link
Contributor

@schtibe schtibe commented Aug 29, 2024

There's no RM version of the page, so we fall back to DE for that link

Test link

Test link

@github-actions github-actions bot added the bug label Aug 29, 2024
@schtibe schtibe requested review from pakb and hansmannj August 29, 2024 07:29
@github-actions github-actions bot changed the title PB 898 Fix rumantsch footer link to geo.admin.ch PB 898 Fix rumantsch footer link to geo.admin.ch - #patch Aug 29, 2024
Copy link

cypress bot commented Aug 29, 2024

web-mapviewer    Run #3151

Run Properties:  status check passed Passed #3151  •  git commit 63cc1cd632: PB-898 Fix RM link for geo.admin.ch with translations
Project web-mapviewer
Branch Review bug-pb-898-fix-rumantsch-footer-link
Run status status check passed Passed #3151
Run duration 04m 11s
Commit git commit 63cc1cd632: PB-898 Fix RM link for geo.admin.ch with translations
Committer Stefan Heinemann
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we shouldn't move that link into our translation file instead of managing i18n stuff for specific language here

@schtibe
Copy link
Contributor Author

schtibe commented Aug 29, 2024

I had the same thought. Then again I wondered if this is ever going to change, and if not, if it's spamming the translation file. I don't know, I'm fine either way, and I trust your experience!
Update: another argument for the translation file would be consistency. I'm gonna do that.
Update2: It already exists in the translations file 😂

@schtibe schtibe changed the base branch from master to develop August 29, 2024 08:48
There's no RM version of the page, so we fall back to DE for that link
@schtibe schtibe force-pushed the bug-pb-898-fix-rumantsch-footer-link branch from 26c706c to ec4fa33 Compare August 29, 2024 08:51
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schtibe schtibe merged commit fa65a11 into develop Aug 29, 2024
6 checks passed
@schtibe schtibe deleted the bug-pb-898-fix-rumantsch-footer-link branch August 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants