-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB 898 Fix rumantsch footer link to geo.admin.ch - #patch #1045
Conversation
web-mapviewer Run #3151
Run Properties:
|
Project |
web-mapviewer
|
Branch Review |
bug-pb-898-fix-rumantsch-footer-link
|
Run status |
Passed #3151
|
Run duration | 04m 11s |
Commit |
63cc1cd632: PB-898 Fix RM link for geo.admin.ch with translations
|
Committer | Stefan Heinemann |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
21
|
Skipped |
0
|
Passing |
210
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we shouldn't move that link into our translation file instead of managing i18n stuff for specific language here
I had the same thought. Then again I wondered if this is ever going to change, and if not, if it's spamming the translation file. I don't know, I'm fine either way, and I trust your experience! |
There's no RM version of the page, so we fall back to DE for that link
26c706c
to
ec4fa33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There's no RM version of the page, so we fall back to DE for that link
Test link
Test link