PB-511: Add request context to all logs #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benschs
force-pushed
the
feat-PB-511-add-request-log
branch
2 times, most recently
from
6b50929 to
a73ab07
Compare
ltshb
approved these changes
Sep 4, 2024
| # last, put everything else in between | ||
| MIDDLEWARE = [ | ||
| 'django_prometheus.middleware.PrometheusBeforeMiddleware', | ||
| 'logging_utilities.django_middlewares.add_request_context.AddToThreadContextMiddleware', |
Contributor
There was a problem hiding this comment.
It would be wise to add a comment why this middleware should be on top.
Add middleware and logging filter to add the django request to all log records.
benschs
force-pushed
the
feat-PB-511-add-request-log
branch
from
a73ab07 to
62f3938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add middleware and logging filter to add the django request to all log records.
Also see: geoadmin/lib-py-logging-utilities#62