PB-2108: Fix scroll in direct navigation #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteiner-swisstopo
approved these changes
Nov 24, 2025
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Nice thanks, it works.
Just had a small comment about maintainability.
.vitepress/theme/index.ts
Outdated
| // Initialize Mermaid after DOM is ready | ||
| initMermaid() | ||
|
|
||
| // Initial scroll to active sidebar item, with timeout to ensure the SideBar is rendered |
Contributor
There was a problem hiding this comment.
How about adding a sentence to make it clear that this is necessary when using a direct link?
Something like this:
// Without this, the sidebar is not centered on the current article if we come from a different domain and use a direct link.It would not be obvious for me otherwise why this is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link