chore: clean up baggage context #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Merge activity
|
### TL;DR Refactored OpenTelemetry context and baggage handling for improved readability and maintainability. ### What changed? - Simplified the OpenTelemetry context and baggage handling in `eval.py` and `eval_dataset.py` by using variable reassignment instead of creating new variables - Refactored the attribute setting logic in `span_processor.py` to use a loop for handling multiple baggage keys, reducing code duplication ### How to test? 1. Run existing tests to ensure the OpenTelemetry context and baggage functionality still works correctly 2. Verify that spans are still properly created with the correct attributes 3. Check that experiment tracking continues to function as expected ### Why make this change? This refactoring improves code readability and maintainability by: - Reducing variable name complexity (using `context` instead of `context_with_modified_baggage`) - Eliminating redundant code through variable reassignment - Consolidating similar logic in `span_processor.py` into a loop to reduce duplication - Making the code more concise while preserving the same functionality
graphite-app
bot
force-pushed
the
josh/clean-up-python-sdk-test-spans
branch
from
ad1394b to
4f4298b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored OpenTelemetry context and baggage handling for improved readability and maintainability.
What changed?
eval.pyandeval_dataset.pyby using variable reassignment instead of creating new variablesspan_processor.pyto use a loop for handling multiple baggage keys, reducing code duplicationHow to test?
Why make this change?
This refactoring improves code readability and maintainability by:
contextinstead ofcontext_with_modified_baggage)span_processor.pyinto a loop to reduce duplication