Hotfix 1.10.x sup 15603 #1571
Open
Hotfix 1.10.x sup 15603 #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyhun
force-pushed
the
hotfix-1.10.x-sup-15603
branch
from
8525da0 to
e6a21c2
Compare
plyhun
commented
Jan 3, 2024
mdm/orientdb-api/src/main/java/com/gentics/mesh/core/data/dao/MicroschemaDaoWrapper.java
Show resolved
Hide resolved
plyhun
commented
Jan 3, 2024
rest-client/src/main/java/com/gentics/mesh/rest/client/method/SchemaClientMethods.java
Show resolved
Hide resolved
npomaroli
requested changes
Jan 9, 2024
Member
npomaroli
left a comment
npomaroli
left a comment
There was a problem hiding this comment.
This is a new feature (new endpoints), so there is no reason to add it as hotfix.
core/src/main/java/com/gentics/mesh/core/endpoint/schema/SchemaEndpoint.java
Show resolved
Hide resolved
core/src/main/java/com/gentics/mesh/core/endpoint/microschema/MicroschemaEndpoint.java
Show resolved
Hide resolved
core/src/main/java/com/gentics/mesh/core/endpoint/schema/SchemaCrudHandler.java
Show resolved
Hide resolved
core/src/main/java/com/gentics/mesh/core/endpoint/microschema/MicroschemaCrudHandler.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void testReadAssignedProjects() { |
Member
There was a problem hiding this comment.
Add more test cases:
- permissions on schema
- permissions on projects
- paging
- sorting
| } | ||
|
|
||
| @Test | ||
| public void testReadAssignedProjects() { |
Member
There was a problem hiding this comment.
Add more test cases:
- permissions on microschema
- permissions on projects
- paging
- sorting
plyhun
commented
Jan 9, 2024
| private MBeanServer mbs = ManagementFactory.getPlatformMBeanServer(); | ||
|
|
||
| private HibBranchVersionAssignment versionEdge; | ||
| private Object versionEdgeId; |
Contributor
Author
There was a problem hiding this comment.
Refactored to avoid NPEs on test runs.
Contributor
Author
@npomaroli it is declared as SUP though. I may indeed move it under GP (2.1.x), although it will seem to be an unplanned feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
REST EPs for referenced projects of (micro)schema.
Checklist
General
/CHANGELOG.adocOn API Changes