Fix possible pkg fetch error on Windows: "worktree contains unstaged changes"
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in go-git v6, it provide the option to config and set filemode (see: go-git/go-git#1712) The filemode can fix the bug of "worktree contains unstaged changes" on windows.
…tree contains unstaged changes` On Windows system, when running `pkg fetch` a git package, it may exit with an error `worktree contains unstaged changes`. This happens when checkout to a specific git tag or branch or commit hash if the repo contains executable file. On Windows, go-git clone will remove the executable permission, and make the executable files to be marked as modified when running `git status`, which causes go-git checkout failes with an error `worktree contains unstaged changes`. This commit fixed the bug by setting `core.filemode` as false on Windows. see also: go-git/go-git#771
…r the git package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also bug report on go-git: go-git/go-git#771