Skip to content

Fix(fetch): fix "invalid cross-device link" when moving downloaded data from tmp to system cache dir #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genshen merged 1 commit into from
Jan 8, 2026
Merged

Fix(fetch): fix "invalid cross-device link" when moving downloaded data from tmp to system cache dir #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/fetch/src_dl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/go-git/go-git/v5/plumbing/storer"
"github.com/go-git/go-git/v5/plumbing/transport"
"github.com/mholt/archives"
cp "github.com/otiai10/copy"
log "github.com/sirupsen/logrus"
"io"
"net/http"
Expand Down Expand Up @@ -352,8 +353,14 @@ func postDownloadStep(packageName, tempPath, packageCacheDir string) error {
}

// perform renaming: move from tem dir to the system cache dir.
if err := os.Rename(tempPath, packageCacheDir); err != nil {
return err
if err := os.Rename(tempPath, packageCacheDir); err != nil { // try rename
if err := cp.Copy(tempPath, packageCacheDir); err != nil { // try copy and remove
return err
}
// remove the dir
if err := os.RemoveAll(tempPath); err != nil {
return err
}
}
}
return nil
Expand Down