feat: Enhance volume management with dynamic reload and improved error handling #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change CREATE TABLE to CREATE TABLE IF NOT EXISTS for volumes - Change CREATE INDEX to CREATE INDEX IF NOT EXISTS for both indices - Remove dangerous DROP TABLE IF EXISTS that could lose data in production This makes schema migrations safer and prevents data loss during service restarts or upgrades. Generated with [Claude Code](https://claude.com/claude-code)
Add reload_volumes() method that allows reloading volume configuration
from the database without service restart. This is automatically called
after volume add/delete operations via the API.
Changes:
- Add AsyncMailCore.reload_volumes() method
- Call reload_volumes() after POST /volume
- Call reload_volumes() after DELETE /volume/{name}
- Refactor volume loading logic to use 'protocol' field
- Improve configuration comments for clarity
This enables runtime volume configuration updates without downtime.
Generated with [Claude Code](https://claude.com/claude-code)
Enhance error handling throughout the message processing pipeline with proper client notifications via proxy_sync. Changes in core.py: - Store rejected messages in DB and notify via proxy_sync - Add ValueError handling for attachment fetch failures - Raise ValueError instead of silently skipping failed attachments - Ensure all errors are reported to client, not just successful sends - Fix edge case where all messages rejected returns proper response Changes in api.py: - Add RequestValidationError exception handler with detailed logging - Add error logging for add-messages failures with full payload - Import logging module for error tracking Benefits: - Client always receives notification of message status (success or error) - Attachment failures properly block message sending - Better debugging with detailed validation error logs - No silent failures or incomplete email sends Generated with [Claude Code](https://claude.com/claude-code)
Update volume-related tests to align with current API requirements and fix assertions. Changes: - Add SMTP account configuration in test_message_rejection_invalid_volume - Add account_id field to test messages - Fix assertion in test_volume_api_endpoints (remove ok/volume wrapper) These changes ensure tests properly validate the volume validation logic with required account context. Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive improvements to volume management functionality with support for dynamic reload, robust attachment validation, and complete error notifications to clients.
Changes by Commit
1. fix: Improve volume persistence schema safety
CREATE TABLEtoCREATE TABLE IF NOT EXISTSfor volumesCREATE INDEXtoCREATE INDEX IF NOT EXISTSfor both indicesDROP TABLE IF EXISTSthat could lose data in production2. feat: Add dynamic volume reload functionality
AsyncMailCore.reload_volumes()method for runtime reconfigurationPOST /volumeandDELETE /volume/{name}protocolfield (genro-storage standard)3. feat: Improve error handling and client notifications
ValueErrorhandling for attachment fetch failuresRequestValidationErrorexception handler with detailed logging4. test: Fix volume tests for account_id requirement
test_message_rejection_invalid_volumeaccount_idfield to test messagestest_volume_api_endpointsBenefits
Testing
All changes have corresponding test updates and have been validated against a running service instance.
Generated with Claude Code