Repository navigation
feat(fees): charge LLM tokens and permit deploy balance fees ✨ #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule v0.3.x
updated
11 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: genlayerlabs/genvm-manager
Length of output: 10124
🤖 get_repo_knowledge executed:
get_repo_knowledge genlayerlabs/genvm-manager /tmp/coderabbit-repo-knowledge/genlayerlabs-genvm-manager-ffe41279/learningsLength of output: 562
🏁 Script executed:
Repository: genlayerlabs/genvm-manager
Length of output: 11018
🏁 Script executed:
Repository: genlayerlabs/genvm-manager
Length of output: 10925
🏁 Script executed:
Repository: genlayerlabs/genvm-manager
Length of output: 17943
Correct the startup permission rule.
The storage wording is valid. “Every permission in it” refers to the complete contract-owned permission set represented by the field, not only the bits set in storage. The unconditional rule in
docs/website/src/spec/03-vm/02-meta-properties.rstis also correct for v0.3.The conflict is in
docs/website/src/spec/03-vm/01-startup.rst. Its startup and Initial Entry rules say thatcan_use_balance_for_message_feesis read from the root slot even for the deployment runner. State that deployment receives every contract-owned permission unconditionally, while non-deployment loads read the permission bitfield from the root slot.🤖 Prompt for AI Agents