Skip to content

feat(fees): charge LLM tokens and permit deploy balance fees ✨ - #43

Merged
kp2pml30 merged 1 commit into
v0.3-devfrom
pr/v0.3/fix/deploy-use-balance
Sep 18, 2026
Merged

kp2pml30 merged 1 commit into
v0.3-devfrom
pr/v0.3/fix/deploy-use-balance

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Auto-opened executor mirror of genlayerlabs/genvm-manager#44.

Carries the executor-side work for that manager PR. The manager branch update fast-forwards v0.3-dev to its pinned commit after landing.

Summary by CodeRabbit

  • Bug Fixes
    • Deployment executions now correctly receive contract-owned permissions configured during construction.
    • Deployment message-fee checks now correctly recognize balance-based permissions as enabled by default.
    • Non-deployment executions continue to use stored permission settings.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c9b14f1f-fe5d-4f52-a023-02d7e458d7cf

📥 Commits

Reviewing files that changed from the base of the PR and between 224be9b and e813da5.

⛔ Files ignored due to path filters (10)
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.0.hash is excluded by !**/*.hash, !**/tests/**
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.0.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.0_0.hash is excluded by !**/*.hash, !**/tests/**
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.0_0.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.jsonnet is excluded by !**/tests/**
  • tests/integration/message/use_balance_forbidden/use_balance_forbidden.py is excluded by !**/tests/**
  • tests/integration/message/use_balance_on_deploy/use_balance_on_deploy.0.hash is excluded by !**/*.hash, !**/tests/**
  • tests/integration/message/use_balance_on_deploy/use_balance_on_deploy.0.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/message/use_balance_on_deploy/use_balance_on_deploy.jsonnet is excluded by !**/tests/**
  • tests/integration/message/use_balance_on_deploy/use_balance_on_deploy.py is excluded by !**/tests/**
📒 Files selected for processing (1)
  • executor/src/lib.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Deployment execution now skips contract-owned permission reads. Non-deployment execution retains storage-based permission loading. Balance-based message-fee checks enable deployments by default and continue decoding stored permissions for non-deployments.

Changes

Deployment Permission Handling

Layer / File(s) Summary
Permission loading and fee checks
executor/src/lib.rs
When code is supplied, execution skips the stored permission read and uses no root permission data. Balance-based message-fee checks enable this case by default. Non-deployments continue reading and checking stored permissions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to e813d

The permission-handling change has no verified failure requiring resolution before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main changes: charging LLM token fees and permitting deployment balance fees.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.0)

Clippy execution failed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kp2pml30
kp2pml30 merged commit e813da5 into v0.3-dev Sep 18, 2026
1 check passed
@kp2pml30
kp2pml30 deleted the pr/v0.3/fix/deploy-use-balance branch September 18, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant