Skip to content

Commit

Permalink
Add Adaptive Icons for RN-Tester (facebook#37255)
Browse files Browse the repository at this point in the history 
Summary:
Pull Request resolved: facebook#37255

I've just realized that RN-Tester still ships with a legacy Android icon. Those have been superseeded in API 26 by adaptive icon. On API 33 Android also added support for monochrome icons which we haven't followed up with.

This brings the icon setup of RN Tester similar to one from the template + makes it easier to recognize.

Changelog:
[Internal] [Changed] - Add Adaptive Icons for RN-Tester

Reviewed By: yungsters, NickGerleman, mdvacca

Differential Revision: D45567471

fbshipit-source-id: 51bfe9bb9f99376353ab76e7d54c34b66382b007
  • Loading branch information
@cortinico @facebook-github-bot
cortinico authored and facebook-github-bot committed May 4, 2023
1 parent 88e3130 commit 9e893a9
Show file tree
Hide file tree
Showing 17 changed files with 111 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/rn-tester/android/app/src/main/AndroidManifest.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
android:name=".RNTesterApplication"
android:allowBackup="true"
android:banner="@drawable/tv_banner"
android:icon="@drawable/launcher_icon"
android:icon="@mipmap/ic_launcher"
android:roundIcon="@mipmap/ic_launcher_round"
android:label="@string/app_name"
android:theme="@style/AppTheme">
<activity
Expand Down
Binary file added packages/rn-tester/android/app/src/main/ic_launcher-playstore.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
74 changes: 74 additions & 0 deletions packages/rn-tester/android/app/src/main/res/drawable/ic_launcher_background.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
<?xml version="1.0" encoding="utf-8"?>
<vector
android:height="108dp"
android:width="108dp"
android:viewportHeight="108"
android:viewportWidth="108"
xmlns:android="http://schemas.android.com/apk/res/android">
<path android:fillColor="#282c34"
android:pathData="M0,0h108v108h-108z"/>
<path android:fillColor="#00000000" android:pathData="M9,0L9,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,0L19,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M29,0L29,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M39,0L39,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M49,0L49,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M59,0L59,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M69,0L69,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M79,0L79,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M89,0L89,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M99,0L99,108"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,9L108,9"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,19L108,19"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,29L108,29"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,39L108,39"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,49L108,49"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,59L108,59"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,69L108,69"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,79L108,79"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,89L108,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M0,99L108,99"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,29L89,29"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,39L89,39"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,49L89,49"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,59L89,59"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,69L89,69"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M19,79L89,79"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M29,19L29,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M39,19L39,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M49,19L49,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M59,19L59,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M69,19L69,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
<path android:fillColor="#00000000" android:pathData="M79,19L79,89"
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/>
</vector>
23 changes: 23 additions & 0 deletions packages/rn-tester/android/app/src/main/res/drawable/ic_launcher_foreground.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="108dp"
android:height="108dp"
android:viewportWidth="400"
android:viewportHeight="361">
<group android:scaleX="0.5"
android:scaleY="0.45125"
android:translateX="100"
android:translateY="99.04938">
<path
android:pathData="M200.5,141.29C179.34,141.29 162.19,158.44 162.19,179.6C162.19,200.76 179.34,217.91 200.5,217.91C221.65,217.91 238.81,200.76 238.81,179.6C238.81,158.44 221.65,141.29 200.5,141.29"
android:strokeWidth="1"
android:fillColor="#ffffff"
android:fillType="nonZero"
android:strokeColor="#00000000"/>
<path
android:pathData="M399.97,180.1C399.97,149.99 372.12,123.59 327.77,106.22C328.36,102.31 328.9,98.44 329.28,94.64C333.65,51.39 323.24,20.17 299.97,6.72C273.94,-8.32 237.17,2.6 199.99,32.37C162.81,2.6 126.03,-8.32 100,6.72C76.73,20.17 66.32,51.39 70.69,94.64C71.07,98.44 71.6,102.32 72.2,106.25C68.51,107.66 64.88,109.16 61.39,110.73C21.8,128.54 0,153.2 0,180.1C0,210.2 27.85,236.6 72.2,253.97C71.6,257.88 71.07,261.75 70.69,265.55C66.32,308.81 76.73,340.02 100,353.47C108,358.01 117.06,360.33 126.26,360.19C148.3,360.19 174.04,348.58 199.99,327.82C225.92,348.58 251.67,360.19 273.74,360.19C282.94,360.33 292,358.01 300,353.47C323.27,340.02 333.68,308.81 329.31,265.55C328.93,261.75 328.39,257.88 327.8,253.97C372.15,236.63 400,210.18 400,180.1M273.57,19.07C279.48,18.92 285.33,20.36 290.5,23.22C306.66,32.56 313.91,57.88 310.39,92.7C310.15,95.08 309.86,97.48 309.52,99.89C291.08,94.33 272.2,90.37 253.08,88.04C241.49,72.62 228.61,58.22 214.56,45C236.62,27.94 257.32,19.07 273.56,19.07M265.98,218.23C258.84,230.63 251.07,242.66 242.7,254.25C228.5,255.71 214.24,256.44 199.97,256.43C185.71,256.44 171.45,255.71 157.26,254.25C148.91,242.66 141.16,230.63 134.05,218.23C126.91,205.87 120.43,193.14 114.62,180.1C120.43,167.05 126.91,154.32 134.05,141.96C141.15,129.61 148.87,117.63 157.19,106.06C171.41,104.57 185.69,103.82 199.99,103.83C214.25,103.82 228.51,104.55 242.7,106.01C251.04,117.59 258.8,129.59 265.92,141.96C273.05,154.33 279.54,167.06 285.35,180.1C279.54,193.14 273.05,205.87 265.92,218.23M295.06,204.11C299.54,216.33 303.22,228.84 306.07,241.54C293.69,245.4 281.08,248.45 268.31,250.65C273.16,243.33 277.87,235.7 282.42,227.78C286.92,219.96 291.14,212.06 295.12,204.17M173.19,274.64C181.97,275.17 190.93,275.48 200,275.48C209.07,275.48 218.09,275.17 226.88,274.64C218.55,284.63 209.57,294.07 200,302.89C190.45,294.07 181.5,284.63 173.19,274.64ZM131.68,250.62C118.9,248.43 106.28,245.39 93.9,241.54C96.74,228.86 100.41,216.37 104.87,204.17C108.79,212.06 113,219.96 117.57,227.78C122.14,235.61 126.87,243.32 131.68,250.65M104.87,156.01C100.42,143.85 96.77,131.41 93.93,118.78C106.28,114.92 118.87,111.87 131.61,109.64C126.78,116.94 122.05,124.51 117.5,132.41C112.94,140.3 108.78,148.1 104.8,156.01M226.8,85.54C218.02,85 209.06,84.69 199.92,84.69C190.85,84.69 181.91,84.98 173.11,85.54C181.41,75.55 190.37,66.11 199.92,57.29C209.49,66.11 218.46,75.54 226.8,85.54ZM282.39,132.41C277.82,124.48 273.09,116.85 268.21,109.53C281.02,111.73 293.66,114.78 306.07,118.65C303.22,131.33 299.56,143.82 295.1,156.03C291.18,148.13 286.96,140.23 282.4,132.42M89.64,92.72C86.07,57.91 93.37,32.57 109.51,23.23C114.69,20.38 120.53,18.94 126.44,19.08C142.68,19.08 163.38,27.95 185.44,45.02C171.38,58.24 158.49,72.65 146.89,88.08C127.78,90.42 108.9,94.37 90.45,99.89C90.12,97.48 89.83,95.09 89.6,92.72M69.21,128.11C71.38,127.17 73.6,126.23 75.86,125.29C80.3,144.03 86.31,162.37 93.85,180.1C86.3,197.86 80.28,216.23 75.84,235.01C39.89,220.25 19.05,199.8 19.05,180.1C19.05,161.42 37.39,142.48 69.21,128.11ZM109.51,336.96C93.37,327.62 86.07,302.28 89.64,267.47C89.87,265.1 90.17,262.71 90.49,260.28C108.93,265.84 127.81,269.81 146.93,272.14C158.52,287.56 171.41,301.97 185.45,315.2C154.71,338.98 126.61,346.82 109.55,336.96M310.37,267.47C313.9,302.29 306.65,327.62 290.49,336.96C273.44,346.84 245.34,338.98 214.6,315.2C228.64,301.97 241.52,287.56 253.11,272.14C272.23,269.81 291.11,265.84 309.55,260.28C309.89,262.71 310.17,265.1 310.41,267.47M324.21,234.99C319.77,216.21 313.74,197.85 306.19,180.1C313.74,162.33 319.76,143.96 324.2,125.18C360.08,139.94 380.98,160.39 380.98,180.1C380.98,199.8 360.14,220.25 324.19,235.01"
android:strokeWidth="1"
android:fillColor="#ffffff"
android:fillType="nonZero"
android:strokeColor="#00000000"/>
</group>
</vector>
Binary file removed packages/rn-tester/android/app/src/main/res/drawable/launcher_icon.png
View file
Binary file not shown.
6 changes: 6 additions & 0 deletions packages/rn-tester/android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@drawable/ic_launcher_background"/>
<foreground android:drawable="@drawable/ic_launcher_foreground"/>
<monochrome android:drawable="@drawable/ic_launcher_foreground"/>
</adaptive-icon>
6 changes: 6 additions & 0 deletions packages/rn-tester/android/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@drawable/ic_launcher_background"/>
<foreground android:drawable="@drawable/ic_launcher_foreground"/>
<monochrome android:drawable="@drawable/ic_launcher_foreground"/>
</adaptive-icon>
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-hdpi/ic_launcher.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-mdpi/ic_launcher.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xhdpi/ic_launcher.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.webp
View file
Binary file not shown.
Binary file added packages/rn-tester/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.webp
View file
Binary file not shown.

0 comments on commit 9e893a9

Please sign in to comment.