Balance date is not read correctly, it uses current date/time

[yulkusal]

The date of balance is not read correctly from xml file.
Instead it uses current timestamp.
I attached an example file and a short script.

script.php
CAMT53.example.xml.txt

[PowerKiKi]

Fixed in https://github.com/genkgo/camt/releases/tag/2.10.1

[frederikbosch]

This is a breaking change. I have a project class that implements Genkgo\Camt\Decoder\DateDecoderInterface and it is now broken because it does not have the new fromDateAndDateTimeChoice method. I don't think it should be inside that interface honestly. The DateDecoderInterface should be xml unaware and just parse dates into a \DateTimeImmutable, as it was. The fromDateAndDateTimeChoice method should be inside the XML implementations.

[PowerKiKi]

Fair enough, I'll patch that

[frederikbosch]

@PowerKiKi, faster than his shadow!

[PowerKiKi]

Fixed in https://github.com/genkgo/camt/releases/tag/2.10.2.

I am curious though, why/how do you use an alternative implementation of that interface ? I was under the impression that this interface is pretty much useless because the implementation is always instantiated internally directly, so there is no opportunity to use an alternative. Did I miss something ?

[frederikbosch]

Banks might use a date-time notation that is not directly supported by PHP through new DateTimeImmutable. With the interface you could implement your own date parser, which I have.

I don't know, however, how useful it still is nowadays. PHP has been accepting many more date formats over the years. It could very well be that my own DateDecoderInterface implementations are covered now by default.

[PowerKiKi]

In all our code and the specs, I couldn't find anything that is not ISO 8601. I suppose PHP would indeed be able to handle those natively 🤞