feat(#81): conway update #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4TT1L4
reviewed
Aug 30, 2024
| WH $ \case | ||
| GYConversionException convErr → someBackendError $ tShow convErr | ||
| GYQueryUTxOException txErr → someBackendError $ tShow txErr | ||
| e@(GYBuildTxException buildErr) → case buildErr of |
Contributor
There was a problem hiding this comment.
It would be nice if the special cases here could be covered by tests.
I don't see any test changes in this PR. I would expect to see some updated tests when such logic changes.
Contributor
Author
There was a problem hiding this comment.
It is largely governed by type system. There is no longer BuildTxException, IIRC it's renamed to GYBuildTxError which no longer has Exception instance so it cannot be thrown in first place. This GYBuildTxError is now part of GYBuildTxException and so there has been reordering of these error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.