Remove captcha on examples#103
Merged
Merged
Conversation
josephniel
previously approved these changes
May 17, 2019
narusemotoki
previously approved these changes
May 17, 2019
narusemotoki
left a comment
narusemotoki
left a comment
Contributor
There was a problem hiding this comment.
LGTM
You don't bump version number because we don't need to release?
ryvasquez
dismissed stale reviews from narusemotoki, josephniel, and perseusl
via
May 17, 2019 03:47
e6e4a93
Contributor
Author
|
you should probably rebase and double check the CI 🙂 |
Contributor
Author
|
@jeanklingler sure I will rebase, however the error in CI only occurring in python3.3 |
ryvasquez
force-pushed
the
166052278-remove-captcha-validation
branch
from
May 17, 2019 04:36
e6e4a93 to
c788771
Compare
ryvasquez
force-pushed
the
166052278-remove-captcha-validation
branch
from
May 17, 2019 06:31
c788771 to
c7950d1
Compare
ryvasquez
marked this pull request as ready for review
May 17, 2019 06:33
narusemotoki
approved these changes
May 17, 2019
narusemotoki
left a comment
narusemotoki
left a comment
Contributor
There was a problem hiding this comment.
gengo.py is changed. Good to change the version number.
carmisancha
approved these changes
May 17, 2019
Contributor
Author
|
@narusemotoki im not sure if its necessary, we dont change any implementation of behavior. maybe its not needed for this change. also I will release the |
Contributor
|
But otherwise we can't upload this library to PyPI because version is conflicting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description