[ch-combo-box-render] Added support to customize the max size of the popover and fixed ch-popover not enforcing maximum sizes
#553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom vars not working in the ch-popover
…popover The --ch-combo-box__popover-max-block-size and --ch-combo-box__popover-max-inline-size custom vars are added to the ch-combo-box-render to support customizing the maximum size of the popover.
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ncamera
added
fix
ncamera
changed the title
[ch-combo-box-render] Add support to customize the max size of the popover and fixed ch-popover not enforcing maximum sizes[ch-combo-box-render] Added support to customize the max size of the popover and fixed ch-popover not enforcing maximum sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes we propose in this PR
[ch-popover]Fixed--ch-popover-max-block-sizeand--ch-popover-max-inline-sizecustom vars not working in thech-popover.[ch-combo-box-render]Added support to customize the max size of the popover.The
--ch-combo-box__popover-max-block-sizeand--ch-combo-box__popover-max-inline-sizecustom vars are added to the ch-combo-box-render to support customizing the maximum size of the popover.Also, fix minor regression introduced by #554 (which was not included in any release).