Mark "lit" dependency as external to optimize bundle size and avoid issues when mixing Lit dependencies #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "lit" dependency is now marked as external, meaning it won't be bundled with the library. This improves code reuse if another library that uses chameleon also uses Lit, and can also fix some issues as it won't mix Lit versions for the development server (because Chameleon was bundling Lit in prod mode, but another libraries use Lit in "dev" mode for the dev server).
ncamera
added
fix
ncamera
changed the title
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ncamera
added
the
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes we propose in this PR
The "lit" dependency is now marked as external, meaning it won't be bundled with the library. This improves code reuse if another library that uses chameleon also uses Lit, and can also fix some issues as it won't mix Lit versions for the development server (because Chameleon was bundling Lit in prod mode, but another libraries use Lit in "dev" mode for the dev server).
Breaking changes
From now on, a build tool (like Vite) with a package manager (like npm, yarn, pnpm or bun) must be used to run Chameleon.