[ch-combo-box-render] Fix value emission with debounce even when the selection is confirmed without strict filters
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the selection is confirmed with filters
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ncamera
added
fix
ncamera
changed the title
[ch-combo-box-render] Fix emitting the value with debounce, even when the selection is confirmed with no strict filters[ch-combo-box-render] Fix value emission with debounce even when the selection is confirmed without strict filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
ch-combo-box-renderhad no strict filters applied, the user would typed a new value and immediately confirm the new value by pressing Enter or Tab keys, the value event was debounced, even though the selection was confirmed.Now, we are no longer debouncing the input event emission for this case.