Improve default values and property names in ch-tab-render and ch-flexible-layout-render controls
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b-render Also, do not display the close button by default
Breaking changes: - Do not display the close button by default
…tab-render Breaking changes: - Disable dragOutside by default
Breaking changes: - Disable dragOutside by default
Breaking changes: - By default disable sortable tab buttons in the "tabbed" type leafs.
ncamera
added
feature
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ncamera
changed the title
ch-tab-render and ch-flexible-layout-render controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes we propose in this PR:
Add
closeButtonproperty inch-flexible-layout-render.Add
dragOutsideproperty inch-flexible-layout-render.Add
sortableproperty inch-flexible-layout-render.Breaking changes
Renamed the
closeButtonHiddenproperty tocloseButtonin thech-tab-renderandch-flexible-layout-rendercontrols.The
closeButtonwill no longer be displayed by default in thech-tab-renderandch-flexible-layout-rendercontrols.Renamed the
dragOutsideDisabledproperty todragOutsidein thech-tab-renderandch-flexible-layout-rendercontrols.The
dragOutsideproperty will no longer be enabled by default in thech-tab-renderandch-flexible-layout-rendercontrols.By default, disable
sortabletab buttons on the "tabbed" type leafs in thech-flexible-layout-render.