[ch-combo-box] Add support for strict filters and solve the vast majority of keyboard issues
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, the popover will close if the click is triggered on any other element than the popover and the `actionElement`.
…seOnClickOutside = true
✅ Deploy Preview for gx-chameleon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ncamera
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes we propose in this PR:
Fixes:
closeOnClickOutsideproperty inch-popover.With this change, the popover will close if the click is triggered on any other element than the popover and the
actionElement.Features:
Add support for strict filters and solve the vast majority of keyboard issues.
Add support for closing the
ch-popovercontrol on escape key whencloseOnClickOutside = true.Add support to display the icon of the selected item in th
ch-combo-boxcontrol.