Skip to content

Fixes and improvements for combo-box control #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 3, 2024
Merged

Fixes and improvements for combo-box control #297

merged 12 commits into from
May 3, 2024

Conversation

@ncamera
Copy link
Collaborator

@ncamera ncamera commented May 3, 2024

Changes we propose in this PR:

  • Fixes:

    • Fix for combo-box not working without borders.
    • Make inline the combo-box to match the native implementation.
    • Improve memory usage by reducing event handlers on disabled items.
    • Remove autocomplete display in native input.

  • Features:

    • Add support to update the current selected value on hover.
    • Add support to resize the control by dragging the edges or corners.
    • Make the minimum inline size of the popover match the combo-box's inline size.

@ncamera ncamera added fix Bug fix pull request feature Feature implementation pull request target: minor This PR is targeted for the next minor release accessibility Fix or feature related to accessibility performance Work related to imporving the performance in the library labels May 3, 2024
@netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for gx-chameleon ready!

Name Link
🔨 Latest commit fefd97e
🔍 Latest deploy log https://app.netlify.com/sites/gx-chameleon/deploys/663524c879400d0008889705
😎 Deploy Preview https://deploy-preview-297--gx-chameleon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ncamera ncamera merged commit 3f55143 into main May 3, 2024
@ncamera ncamera deleted the fix/combo-box branch May 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accessibility Fix or feature related to accessibility feature Feature implementation pull request fix Bug fix pull request performance Work related to imporving the performance in the library target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncamera