- Fix collection serialization for rest procedures and dataproviders #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
…tput parameter. Reverts to default wrapped status for this case
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
… as API objects. Changed Attribute GxUnWrappedJson for GxJsonSerialization(type)
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit ee9000f
|
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit ee9000f
|
Collaborator
Manual cherry pick to beta success |
…ith Json response
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit 8ab5213
|
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Manual cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
claudiamurialdo
left a comment
claudiamurialdo
left a comment
There was a problem hiding this comment.
The two methods GetWrappedStatus and SetWrappedStatus could be internal?
|
|
||
| private string wrappedStatus = ""; | ||
|
|
||
| public string GetWrappedStatus() |
Collaborator
There was a problem hiding this comment.
Consider using internal methods over public ones whenever possible.
| return wrappedStatus; | ||
| } | ||
|
|
||
| public void SetWrappedStatus(string value) |
Collaborator
There was a problem hiding this comment.
Can it be internal instead of public?
- Change SetWrappedStatus function as internal.
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Issue 106797
Collaborator
Cherry pick to beta success |
AlejandroP
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property Json Collection Serialization , was not being used in REST procedures / Dps
Issue :
106797