-
Notifications
You must be signed in to change notification settings - Fork 12
Upgrade Microsoft.Data.SqlClient from 1.1.4 to 2.1.2 #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version supports Azure Active Directory authentication.
Collaborator
Cherry pick to beta success |
…use of known vulnerabilities) Upgrade Microsoft.IdentityModel.* Version=6.5.1 to Version=6.8.0 required by Microsoft.Data.SqlClient 2.1.2
Collaborator
Cherry pick to beta success |
…de Microsoft.IdentityModel* for .NET Framework projects.
Collaborator
Cherry pick to beta success |
The condition is checked at TestPackageVersionConsistencyAcrossProjects
Collaborator
Cherry pick to beta success |
sjuarezgx
previously approved these changes
Aug 10, 2023
…Azure Active Directory authentication method.
Collaborator
Cherry pick to beta success |
…Azure Active Directory authentication method.
…/DotNetClasses into driver-sqlserver-net
Collaborator
Cherry pick to beta failed, 0 conflicted files in commit 611f6b2 (warning: no changes merged) |
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta success |
…. Explicitly add the reference to newtonsoft since it was removed with the upgrade of Microsoft.Data.SQLClient 1.1.4 to 2.1.2 (newtonsoft was a transitive dependency of Microsoft.Data.SQLClient 1.1.4, but not for 2.1.2).
Collaborator
Cherry pick to beta success |
sjuarezgx
previously approved these changes
Aug 14, 2023
… package. Explicitly add the reference to newtonsoft since it was removed with the upgrade of Microsoft.Data.SQLClient 1.1.4 to 2.1.2 (newtonsoft was a transitive dependency of Microsoft.Data.SQLClient 1.1.4, but not for 2.1.2)." This reverts commit ba5be26.
Collaborator
Cherry pick to beta success |
claudiamurialdo
added a commit
that referenced
this pull request
Aug 14, 2023
It will be needed for PR #862
…ors related to Microsoft.Data.SqlClient as well as any missing dependencies.
Collaborator
Cherry pick to beta success |
…ditional connection string attributes. Cannot use 'Authentication' with 'Integrated Security'.
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version supports Azure Active Directory authentication.
Issue:104030