Skip to content

Cache failed dynamic calls to avoid loading all assemblies each time. #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
+7 −8
Merged

Cache failed dynamic calls to avoid loading all assemblies each time. #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions dotnet/src/dotnetframework/GxClasses/Helpers/GXMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,8 @@ static public Type FindType(string defaultAssemblyName, string ns, string clssWi
string clss = string.IsNullOrEmpty(ns) ? clssWithoutNamespace : string.Format("{0}.{1}", ns, clssWithoutNamespace);
Type objType = null;
string appNS;
loadedAssemblies.TryGetValue(clss, out objType);
if (objType == null)
{
if (!loadedAssemblies.TryGetValue(clss, out objType))
{
if (defaultAssembly != null)
{
try
Expand Down Expand Up @@ -199,15 +198,15 @@ static public Type FindType(string defaultAssemblyName, string ns, string clssWi
}
}

if (objType == null)
{
GXLogging.Error(log, "Failed to load type: " + clss + " from currentdomain");
throw new GxClassLoaderException("Failed to load type: " + clss);
}
}

loadedAssemblies[clss] = objType;
}
if (objType == null)
{
GXLogging.Error(log, "Failed to load type: " + clss + " from currentdomain");
throw new GxClassLoaderException("Failed to load type: " + clss);
}
return objType;

}
Expand Down