JSON to be delivered in HTML must not escape ampersand #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… later in HtmlEncodeInputValue.
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Collaborator
Cherry pick to beta success |
ggallotti
previously approved these changes
May 15, 2023
It is already delimited outside HtmlEncodeJsonValue use.
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
added a commit
that referenced
this pull request
May 17, 2023
* JSON to be delivered in HTML must not escape ampersand, it is escaped later in HtmlEncodeInputValue. * Do not delimit encoded json at HtmlEncodeJsonValue. It is already delimited outside HtmlEncodeJsonValue use. (cherry picked from commit ba9c5eb)
claudiamurialdo
added a commit
that referenced
this pull request
May 23, 2023
* JSON to be delivered in HTML must not escape ampersand, it is escaped later in HtmlEncodeInputValue. * Do not delimit encoded json at HtmlEncodeJsonValue. It is already delimited outside HtmlEncodeJsonValue use. (cherry picked from commit ba9c5eb)
claudiamurialdo
added a commit
that referenced
this pull request
Jul 4, 2023
* JSON to be delivered in HTML must not escape ampersand, it is escaped later in HtmlEncodeInputValue. * Do not delimit encoded json at HtmlEncodeJsonValue. It is already delimited outside HtmlEncodeJsonValue use. (cherry picked from commit ba9c5eb)
claudiamurialdo
added a commit
that referenced
this pull request
Feb 21, 2024
* JSON to be delivered in HTML must not escape ampersand, it is escaped later in HtmlEncodeInputValue. * Do not delimit encoded json at HtmlEncodeJsonValue. It is already delimited outside HtmlEncodeJsonValue use. (cherry picked from commit ba9c5eb) # Conflicts: # dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs # dotnet/test/DotNetCoreUnitTest/HttpUtils/HttpUtils.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is escaped later in HtmlEncodeInputValue.
Issue:102386