Support double values as partition keys in CosmosDB #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
previously approved these changes
Apr 5, 2023
Collaborator
claudiamurialdo
left a comment
claudiamurialdo
left a comment
There was a problem hiding this comment.
GetAttValue(i).ToString() is using the current culture to create a string. It should specify the culture to get the same result in any configuration.
| if (GetAttValue(i) is DateTime value) | ||
| return value; | ||
| return default(DateTime); | ||
| DateTime.TryParseExact(GetAttValue(i).ToString(), CosmosDBHelper.ISO_DATE_FORMAT, CultureInfo.InvariantCulture, DateTimeStyles.AdjustToUniversal, out DateTime dt); |
Collaborator
There was a problem hiding this comment.
GetAttValue(i).ToString() is using the current culture to create a string. It should specify the culture to get the same result in any configuration.
Collaborator
Cherry pick to beta success |
sjuarezgx
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:102208