Skip to content

Refactor procs and http procs to allow mocking test #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 16, 2023
Merged

Refactor procs and http procs to allow mocking test #776

merged 18 commits into from
Jun 16, 2023

Conversation

@claudiamurialdo
Copy link
Collaborator

@claudiamurialdo claudiamurialdo commented Feb 22, 2023 •
edited
Loading

Remove WebControl as a base clase of GXHttpHandler. Next change will add GXBaseObject as a base class, as in .NETCORE.
Issue:101766

@claudiamurialdo
Refactor procs and http procs to allow having a common base object an…
73660bb 
…d intercept Execute methods.

Remove WebControl as a base clase of GXHttpHandler. Next change will add GXBaseObject as a base class, as in .NETCORE.
@genexusbot
Copy link
Collaborator

genexusbot commented Feb 22, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests February 22, 2023 23:29 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Feb 22, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests February 22, 2023 23:36 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Feb 23, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests February 23, 2023 21:19 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Feb 24, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests February 24, 2023 17:58 — with GitHub Actions Inactive
@claudiamurialdo
Simplify IGxMock interface: remove CanHandle Method.
0b3ae01 
Handle may success depending on the values of the parameters.
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 2, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 2, 2023 18:13 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 7, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 7, 2023 14:10 — with GitHub Actions Inactive
@claudiamurialdo
Move common methods to GXBaseObject.
c6e338a 
Add a virtual ExecutePrivate to move executePrivateCatch from generated code to base class.
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 8, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 8, 2023 17:37 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 9, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo had a problem deploying to external-storage-tests March 9, 2023 13:40 — with GitHub Actions Failure
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 9, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 9, 2023 13:51 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo changed the title Refactor procs and http procs to allow having a common base object Refactor procs and http procs to allow mocking test Mar 9, 2023
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 13, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 13, 2023 13:38 — with GitHub Actions Inactive
@claudiamurialdo
Submit was not working for objects calling the submit method itself.
111aa0b 
Its the case of offlinedatabase that for gxconfirmsync entrypoint calls the method this.executeSubmit.
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 29, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests March 29, 2023 22:09 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo had a problem deploying to external-storage-tests March 30, 2023 13:34 — with GitHub Actions Failure
@genexusbot
Copy link
Collaborator

genexusbot commented Mar 30, 2023

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Apr 1, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 1, 2023 12:41 — with GitHub Actions Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 3, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 3, 2023 21:22 — with GitHub Actions Inactive
@claudiamurialdo
Submit method must be done in the same instance to support passing pa…
1e6e678 
…rameters: the current instance already has the parameters values assigned in the current instance variables.
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 5, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 5, 2023 20:59 — with GitHub Actions Inactive
@claudiamurialdo
Compatibility fix for HttpHandler for each object: Restore WebControl…
47a7e02 
… as a base class for GXHttpHandler in .NET Framework.
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 19, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 19, 2023 13:32 — with GitHub Actions Inactive
@claudiamurialdo
Compatibility fix for HttpHandler for each object: Restore WebControl…
b1c77f1 
… as a base class for GXHttpHandler in .NET Framework.

Keep methods PropagateCulture and Submit for .NET Framework GXWebProcedure.
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 19, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 19, 2023 13:43 — with GitHub Actions Inactive
@claudiamurialdo
Compatibility fix for HttpHandler for each object: Restore WebControl…
d97fa5d 
… as a base class for GXHttpHandler in .NET Framework.

Add methods ExecuteEx and ExecutePrivate to GXHttpHandler in .NET Framework.
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 19, 2023

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests April 19, 2023 17:58 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo merged commit 9c70389 into master Jun 16, 2023
@claudiamurialdo claudiamurialdo deleted the proc-refactoring branch June 16, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@claudiamurialdo @genexusbot