Repository navigation
fix: add OpenAI adapter deregistration - #1676
Merged
jakelorocco merged 2 commits intoSep 28, 2026
Merged
jakelorocco merged 2 commits into
jakelorocco merged 2 commits into
Conversation
Assisted-by: Codex Signed-off-by: Bruney <Brun3y@gmail.com>
jakelorocco
reviewed
Sep 25, 2026
jakelorocco
left a comment
Contributor
There was a problem hiding this comment.
thanks for the contribution! one small test change but looks good besides that
Assisted-by: Codex Signed-off-by: Bruney <Brun3y@gmail.com>
Contributor
Author
|
@jakelorocco thanks for the comment, I've already applied your recommendation. |
jakelorocco
approved these changes
Sep 28, 2026
Merged
via the queue into
generative-computing:main
with commit Sep 28, 2026
f8639d2
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1624
Description
Adds
OpenAIBackend.remove_adapter()as the inverse of adapter registration.Testing
Verification performed locally:
uv run pytest test/backends/test_adapters/test_adapter_mixin.py test/backends/test_openai_intrinsics_unit.py -m "not qualitative"— 43 passed.uv run pre-commit run --files ...— all applicable hooks passed.uv run pytest test/ -m "not qualitative"— 4,650 passed; 5 unrelated LiteLLM/Ollama tests failed because the local Ollama endpoint returned 404 for the unavailablegranite4.2:3bmodel.Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.