feat(terminal): Ability to set custom terminal fonts#683
feat(terminal): Ability to set custom terminal fonts#683NoumanAMalik wants to merge 2 commits intogeneralaction:mainfrom
Conversation
|
@NoumanAMalik is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
|
thank you ! will review |
|
Great idea @NoumanAMalik. A couple thoughts, it'd be great to have some save indicator or knowing whether the font has been set. Two other fixes needed before merg:
Let me know if you want to take another stab or whether I should finish it 🙏 |
|
bet, I'll get to it and make another commit EOD |
|
When typing inside the text input field, there is a clear button as well as an keyboard shortcut badge showing the user to click enter to save. demo.-.save.indicator.movFor the 2 bugs:
@rabanspiegel if you see any other issues, I'd be glad to address them. |
|
Thank you, will review by EOD! |
In the Settings modal, under Interface, at the bottom, added a new field to add a custom.

Whatever is added in this input, gets appended at the beginning of the default font families that were already defined from before. In the TerminalSessionManager.ts, I also added an event listener to automatically refresh the terminal whenever the font is changed, so the user sees it update right away.